<html>
<head><meta charset="utf-8"><title>Trait implementation self-links · rustdoc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/index.html">rustdoc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html">Trait implementation self-links</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="223756180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223756180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223756180">(Jan 23 2021 at 15:57)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/32558">#32558</a> changed the rendering of traits "implementors" section to not self-link. However, in the "implementation on foreign traits" section, implementations <em>do</em> self-link. Should those be united? If so, what is the preferred behavior?</p>



<a name="223756236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223756236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223756236">(Jan 23 2021 at 15:58)</a>:</h4>
<p>Maybe the link isn't important, but we should keep the color?</p>



<a name="223757009"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223757009" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223757009">(Jan 23 2021 at 16:15)</a>:</h4>
<p>I think it would be nice to, rather than special casing traits, detect whenever a link points to the current page without an anchor and strip it if so</p>



<a name="223757014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223757014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223757014">(Jan 23 2021 at 16:15)</a>:</h4>
<p>Keeping the color sounds reasonable</p>



<a name="223772891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223772891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223772891">(Jan 23 2021 at 20:11)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/266220-rustdoc/topic/Trait.20implementation.20self-links/near/223757009">said</a>:</p>
<blockquote>
<p>I think it would be nice to, rather than special casing traits, detect whenever a link points to the current page without an anchor and strip it if so</p>
</blockquote>
<p>I feel like that would be hard to implement without much benefit though.</p>



<a name="223773191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223773191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223773191">(Jan 23 2021 at 20:18)</a>:</h4>
<p>well, then why do it for traits?</p>



<a name="223773233"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223773233" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223773233">(Jan 23 2021 at 20:18)</a>:</h4>
<p>I don't see much point in <em>only</em> doing this for traits and nothing else</p>



<a name="223773273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223773273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223773273">(Jan 23 2021 at 20:19)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/266220-rustdoc/topic/Trait.20implementation.20self-links/near/223773233">said</a>:</p>
<blockquote>
<p>I don't see much point in <em>only</em> doing this for traits and nothing else</p>
</blockquote>
<p>Which is why I'd personally prefer to revert <a href="https://github.com/rust-lang/rust/issues/32558">#32558</a> <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="223773360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223773360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223773360">(Jan 23 2021 at 20:21)</a>:</h4>
<p>I would be fine with that</p>



<a name="223778696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223778696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223778696">(Jan 23 2021 at 21:51)</a>:</h4>
<p>Same here I think.</p>



<a name="223778968"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223778968" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223778968">(Jan 23 2021 at 21:57)</a>:</h4>
<p>Would that need a FCP?</p>



<a name="223778973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223778973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223778973">(Jan 23 2021 at 21:58)</a>:</h4>
<p>I'll just open a PR for now</p>



<a name="223779012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223779012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223779012">(Jan 23 2021 at 21:58)</a>:</h4>
<p>Do what you want with it :D</p>



<a name="223781191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223781191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223781191">(Jan 23 2021 at 22:18)</a>:</h4>
<p>Not sure if it would need an FCP, but should be a pretty small change :)</p>



<a name="223782646"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/Trait%20implementation%20self-links/near/223782646" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/Trait.20implementation.20self-links.html#223782646">(Jan 23 2021 at 22:55)</a>:</h4>
<p>Opened <a href="https://github.com/rust-lang/rust/issues/81313">#81313</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>